Light Freshness Edit: ASP.NET - Caching#37087
Conversation
|
@tdykstra - Refreshed topics for your review. See the top comment for details. |
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
Reviewed. Great work! A few minor items suggested.
I will wait for @tdykstra to review before this is merged since he owns these topics.
| The output caching middleware can be used in all types of ASP.NET Core apps: [Minimal APIs](xref:fundamentals/minimal-apis), [Web API with controllers](xref:web-api/index), [MVC](xref:mvc/overview), and [Razor Pages](xref:razor-pages/index). Code examples are provided for Minimal APIs and controller-based APIs. The controller-based API examples show how to use attributes to configure caching. These attributes can also be used in MVC and Razor Pages apps. | ||
|
|
||
| The code examples refer to a [Gravatar class](https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/performance/caching/output/samples/7.x/Gravatar.cs) that generates an image and provides a "generated at" date and time. The class is defined and used only in [the sample app](https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/performance/caching/output/samples/7.x). Its purpose is to make it easy to see when cached output is being used. For more information, see [How to download a sample](xref:fundamentals/index#how-to-download-a-sample) and [Preprocessor directives in sample code](xref:index#preprocessor-directives-in-sample-code). | ||
| The code examples refer to a [Gravatar class](https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/performance/caching/output/samples/7.x/Gravatar.cs) that generates an image and provides a "generated at" date and time. The class is defined and used only in [the sample app](https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/performance/caching/output/samples/7.x). Its purpose is to make it easy to see when cached output is being used. For more information, see [How to download a sample](xref:fundamentals/index#how-to-download-a-sample) and [Preprocessor directives](/dotnet/csharp/fundamentals/program-structure/preprocessor-directives). |
There was a problem hiding this comment.
@wadepickett - The <xref:index#preprocessor-directives-in-sample-code> link redirects to the top of the Overview page, which provides no information about preprocessor directives. I tried to find a replacement. Can you identify a more appropriate link?
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
|
I deleted my suggestion for the link change for preprocessor-directives, but that also deleted the conversation history. So I'll note it here: The link I suggested resolved to the top of the overview page which made it useless. At some point we deleted that section in the overview. Sorry to mess that up. You aleady had the best link we can provide. Follow up for me: I will also look through the entire repo to see if that original outdated link is anywhere else and get it fixed. Thanks for finding this issue to begin with! |
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
Approved. Great work, thanks!
@tdykstra will also provide a review and then merge.
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
Looks good.
One important update -- there's a new Azure Redis service
tdykstra
dismissed
their stale review
The requested change would have taken us out of the scope of light freshness edit. we will save the Redis change for another issue.
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
Approved, will merge when comments are addressed., except ignore the Redis service change.
|
@tdykstra - Thank you for your review. I applied your requested changes and held off on changes related to comments about changing the Azure Redis service. |
Azure Cache for Redis link replaced with Azure Managed Redis per tdykstra
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
All review suggestions appear to be resolved. Approving and merging.
3 participants
This PR contains light freshness updates to five articles:
For details, see ADO request 568764.
Internal previews